deso-protocol / frontend

DeSo frontend
MIT License
267 stars 136 forks source link

Should post thread hide all replies by the users post creator blocked? #387

Closed tijno closed 3 years ago

tijno commented 3 years ago

This relates to the issue mentioned here and here by @AdityaChaudhary0005 and @FreeTrade

Replies by someone the post owner has blocked are hidden for everyone.

Not sure if this is intentional, or bug.

@maebeam if intentional ill raise cip to propose change.

This uses the post creator pub key - but should it not use the logged in user key ?

https://github.com/bitclout/frontend/blob/cbed73cc0378974597cfa8fef386df53b59bb170/src/app/post-thread-page/post-thread/post-thread.component.ts#L343

ItsAditya-xyz commented 3 years ago

My take on this:

Last but not the least, @maebeam knows it what it feels like being censored even when you are right. IMG_20210815_155138.png

tijno commented 3 years ago

@AdityaChaudhary0005 So its not a bug and its intentional?

If it is intentional then this needs to be discussed as a CIP - hence me being keen to figure out if it is a bug or a "feature"

Note i agree with what you are saying by the way.

But fixing a bug will be much easier then changing this if it was intentional.

ItsAditya-xyz commented 3 years ago

Yeah, to me it looks like it is intentional but we should wait for the response of core Devs 🙂

If it's intentional, we will CIP it and if it's a bug we can do a PR to fix it

FreeTrade commented 3 years ago

I'm assuming it's intentional - if so, perhaps there could be an option to switch it on/off depending on the node operator's preference.

maebeam commented 3 years ago

This is intentional. CIP is welcomed.

tijno commented 3 years ago

@AdityaChaudhary0005 @FreeTrade as you discovered the issue you want to raise the CIP? If not i can do it of course.

FreeTrade commented 3 years ago

No, I'm working on alternative software, so I won't to get too deeply involved with improvements to the BC frontend.