deso-protocol / identity-swift

14 stars 2 forks source link

Using ECIES in the sign transaction worker #5

Closed andyboyd closed 3 years ago

andyboyd commented 3 years ago

Hooking up the transaction signer to actually use the crypto functions

andyboyd commented 3 years ago

@maebeam , I guess there's going to be more work to do on this one when the derived keys go in?

andyboyd commented 3 years ago

@maebeam, would you mind having a look at the part of signTransaction that deals with the signatureLength? I'm not entirely sure if filtering the zeroes out from the array works all the time, though so far it always has for the transactions I've tested

maebeam commented 3 years ago

I think filtering the zeroes out should work totally fine. Looks great to me