search

desowin / usbpcap

USB packet capture for Windows
http://desowin.org/usbpcap
902 stars 170 forks source link

Add handling of --extcap-version command line parameter #52

Closed JaapKeuter closed 6 years ago

JaapKeuter commented 6 years ago

Since Wireshark 2.9 the extcap call to query its interface is extended with the extcap-version parameter. The command line option parser is not expecting this, emitting a message on stderr. This change adds the extcap-version parameter to the expected set, to stop the message being emitted on stderr, leaving out any processing of the parameter value itself, which USBPcapCMD does not need, yet.

This would address #51

PS: So far this is untested.

desowin commented 6 years ago

In general I would like to have the command line parameters handling reworked. I think including the actual --extcap options in --help would be good to have.

desowin commented 6 years ago

The AppVeyor was never correctly configured. I might try to give it another try.

JaapKeuter commented 6 years ago

Addressed all concerns, added option '0' now. As said, totally untested.

desowin commented 6 years ago

The master branch now returns success when building with AppVeyor. It does build the windows 8 x64 driver and if the build passes, it is considered a success (regardless if test signing succeeds or fails).

desowin commented 6 years ago

Thank you very much for your contribution.

Could you please squash these commits and rebase them onto current master? Then the AppVeyor should pick this up and the 64-bit version of USBPcapCMD should be available as automated build artifact.

JaapKeuter commented 6 years ago

Let's see if I can rework this as requested.

JaapKeuter commented 6 years ago

Reworked the change as requested. Pushed the result onto a new branch (this one wouldn't work) called extcap-version2.