remove the empty function

despensa-app / despensa-web

Despensa-app es una aplicación que te permite gestionar los productos que compras de forma habitual.

https://despensa-app.nmarulo.dev/

MIT License

4 stars 14 forks source link

remove the empty function #17

Closed Srijan25 closed 2 weeks ago

Srijan25 commented 3 weeks ago

correct this click code remove the empty constructor

deepsource-io[bot] commented 3 weeks ago

Here's the code health analysis summary for commits ff6fe9f..7150530. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	✅ Success	🎯 5 occurences resolved	View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

nmarulo commented 3 weeks ago

@Srijan25 I have left you a comment in the src/app/modules/shopping-list/pages/add-products-shopping-list/add-products-shopping-list.component.ts file. Regarding the other two changes, which deepsource issues refer to these two file changes?

If they are not related to an issue, they do not need to be made in this issue. That refactoring can be left for another issue. Anyway, as it is already done, we leave it as it is.

nmarulo commented 3 weeks ago

Check if you have uploaded all the changes and test it before, please.

nmarulo commented 3 weeks ago

Read the recommendations given by deepsource, I believe that in this case it is ok to do so and there is no need to replace or delete it.

https://app.deepsource.com/gh/despensa-app/despensa-web/issue/JS-0321/occurrences?listindex=0

For example in this PR #19, although I do not accept it for another reason, the solution is also valid for me.

Sometimes the solution may be simpler than you think.