search

dessalines / thumb-key

A privacy-conscious Android keyboard made for your thumbs
GNU Affero General Public License v3.0
1.02k stars 216 forks source link

Swipe input eaten on capitalization/mode switch #371

Open GabrielDTB opened 1 year ago

GabrielDTB commented 1 year ago

Thumb-Key Version 1.12.0

Describe the bug If you hit capitalize, number pad mode, or switch layouts during a swipe input, after pressing but before releasing, the input is not sent and the key is left activated. Using the key again resets the key highlighting. This does not occur when tapping, only swiping.

This often happens to me when using two fingers to type.

To Reproduce Steps to reproduce the behavior:

  1. Start swiping a letter
  2. Swipe capitalize
  3. Release the letter
  4. The key should stay lit up with no input sent

This can also be achieved through tapping number pad mode and through switching layouts by swiping left on #

dessalines commented 1 year ago

The key should stay lit up with no input sent

Why should that be intended behavior? Seems very strange to me.

I don't know that I want to try to support holding actions and state in between pressing and releasing, that seems overly complicated for something as simple as: just wait until you've released a letter before you capitalize.

GabrielDTB commented 1 year ago

I misread in my reply, and it would appear that you misread my original post. This is a bug report, not a feature request. The thing you asked why it would be intended behavior I agree with: It shouldn't be intended behavior. This is the behavior I observed as it is now.

GabrielDTB commented 1 year ago

And to clarify, this is behavior that I observe in normal use just typing relatively quickly when I need to capitalize a letter mid-sentence. My finger don't always lift up off of the key before I hit the next key with the other finger -- it just happens.

dessalines commented 1 year ago

I still don't really understand.

The key should stay lit up with no input sent

You think the key should stay in a "lit up" state, for caps lock?

GabrielDTB commented 1 year ago

That is the how to reproduce section. That is the behavior that you should observe when you perform the listed action. I don't understand what the confusion is.

nejni-marji commented 1 year ago

The key does in fact stay lit up when you interrupt a key swipe with shift, which is probably undesired.

nejni-marji commented 1 year ago

https://github.com/dessalines/thumb-key/assets/10968473/3d9c7278-96c6-4686-bc0e-ea1a4e2ac1ae

dessalines commented 1 year ago

Ah okay I see it now, thx.