"@" character doesn't work on spanish MessagEase layout alphabetic layers

asdkant commented 8 months ago

Steps to reproduce

(configure and) switch to "español messagease"
try to type @ character (bottom-left swipe from "R") on lower or upper case alphabetic layers

Expected behavior

@ is detected

Actual behavior

Either nothing is detected, or the tap symbol (R or r) is detected. The symbol on the numeric layer works fine.

version of the program

2.6.18

Android version

14 (OneUI 6.0)

Device

Samsung Galaxy S21 FE

Other details

This looks like thumb-key is not parsing the layer definition correctly. I checked the code and the layout definition seems correct:

Also tested and reproduced on:

v2.6.16 & v2.6.18 (Galaxy Tab S5e, androdid 11, OneUI 3.1)
v2.6.17 (same S21 FE)
v2.6.18 (Galaxy A52, android 13, OneUI 5.1 )

So it doesn't seem to be device-specific.

Acknowledgements

[X] I have written a short but informative title.
[X] I have updated the app to the latest version.
[X] I have searched the existing issues and this is a new one, NOT a duplicate or related to another open issue.
[X] This is not a question or a discussion, in which case I should have gone to lemmy.ml/c/thumbkey
[X] This is a single bug report, in case of multiple bugs I will open a separate issue for each one (they can always link to each other if related)
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements. 🤡
[X] I have filled out all of the requested information in this form.

dessalines commented 8 months ago

Probably has to do with an incorrect swipetype.

asdkant commented 8 months ago

You mean the SwipeDirection.BOTTOM_LEFT thing? But that's correct:

// lower case
SwipeDirection.BOTTOM_LEFT to
    KeyC(
        display = KeyDisplay.TextDisplay("@"),
        action = KeyAction.CommitText("@"),
        color = ColorVariant.MUTED,
    ),
// upper case
SwipeDirection.BOTTOM_LEFT to
    KeyC(
        display = KeyDisplay.TextDisplay("@"),
        action = KeyAction.CommitText("@"),
        color = ColorVariant.MUTED,
    ),
// numeric
SwipeDirection.BOTTOM_LEFT to 
    KeyC(
        display = KeyDisplay.TextDisplay("@"), 
        action = KeyAction.CommitText("@")
    ),

asdkant commented 8 months ago

How can I properly debug this issue?

dessalines commented 8 months ago

This is incorrect, it needs to be fixed by removing that line (so it uses the default all swipe directions) https://github.com/dessalines/thumb-key/blob/main/app/src/main/java/com/dessalines/thumbkey/keyboards/ESMessageEase.kt#L206

asdkant commented 8 months ago

Ohh, ok, I get it now. I'm working on some changes to this keybard (a rework on the placement of ¿ and ¡ mostly, I've been test driving it for a few days) so I'll include it there and do the PR later today if nobody fixes it before

dessalines / thumb-key