search

dessant / lock-threads

GitHub Action that locks closed issues, pull requests and discussions after a period of inactivity
https://github.com/marketplace/actions/lock-threads
MIT License
313 stars 34 forks source link

[FR] Support locking issues based on the closed date, not updated #14

Closed webknjaz closed 4 years ago

webknjaz commented 5 years ago

Do you think this could be done upstream?

Ref: https://github.com/ansible/ansible/pull/58674#discussion_r300017885

dessant commented 5 years ago

The current implementation locks closed issues that are no longer active, this ensures that issues are generally not bumped, and that no active discussions are stopped. Locking based on the closed date should be easy, but it could cut off people in the middle of a conversation that may be important, even if it happens in a closed issue.

I see your team is worried about spammers periodically posting to keep an issue unlocked indefinitely, but that should be a rare occurrence, and the user should be called out and moderated way before it causes a problem with the locking of the issue.

If this type of spamming becomes a problem, I'd be happy to add the feature, but at the moment I do not see a need for it.

webknjaz commented 5 years ago

@dessant we have this as a part of our workflow also because of a very high volume of contributions/community activity in general on the project. One of my colleagues (@sivel) already runs this task manually from time to time. I just wanted to replace his actions with automation to reduce the maintenance burden. There's a lot more implications we have derived from our workflows, which are much wider than fear of spammers. Currently, it's a blocker which prevents us from even starting to use this bot.

dessant commented 5 years ago

Could you share a concrete implication that was derived from your workflow?

webknjaz commented 5 years ago

It's just that we don't ever look at the closed issues and require creating new ones if somebody wants a new discussion.

dessant commented 5 years ago

In that case you could set the issue to be locked in 1 day of inactivity after closing instead of letting people make comments that will be ignored for a year before locking. Having a buffer of 1 day is also useful in case a new user that is not familiar with your contribution guidelines wants to signal something important about an issue that was just closed, such as a regression.

webknjaz commented 5 years ago

Currently, we don't want to be that strict. And we also have a complex bot which supports more complicated flows. We wanted it to be aligned with what we have now.

cc @mattclay @mkrizek

dessant commented 5 years ago

I'm happy to add the feature, but it must not result in commenters being ignored and then cut off, because that could be damaging for projects. I find it much better to disallow communication on closed issues if the intention is to not look at it, it sets a clear path for the user to communicate in the intended form, and it saves time both for the user and maintainers.