search

dessant / lock-threads

GitHub Action that locks closed issues, pull requests and discussions after a period of inactivity
https://github.com/marketplace/actions/lock-threads
MIT License
313 stars 34 forks source link

Update dependancy to remove const error #18

Closed netniV closed 4 years ago

netniV commented 4 years ago

This fixes the octokit error caused by the Toolkit GitHub action.

thinkyhead commented 4 years ago

Looking forward to this patch. In the meantime, I wonder if it works to use uses: netniV/lock-threads@patch-1? My first attempt seemed to fail silently. I'm about to give it another try….

netniV commented 4 years ago

I would think you'd need to specify using my specific version in your workflow file. However, don't quote me on that as whilst I think you can do, not entirely sure on that as I'm still learning the mysterious art of github actions one thing you could do is add the debugging to see any output.

thinkyhead commented 4 years ago

I used the path from above and when the job ran it gave this ("successful") result… image

netniV commented 4 years ago

That’s interesting. If you turn on the debug etc. does it definitely pull in the later GitHub action sources ? They definitely fixed it in that one from what I read of the sources.

dessant commented 4 years ago

Hi folks! Both package.json and package-lock.json need to be updated by running npm update @actions/github, and then the dist package pulled by workflows needs to be built with ncc by running npm run package. The last step should usually be done by maintainers for security reasons, since it produces a 1 MB file with a diff that is sometimes huge. I'll update all dependencies and release a new version today.

netniV commented 4 years ago

I did see that the other file needs to be updated but figured that was a security thing done by yourself. Glad to have it resolved though :)