dessant / lock-threads

GitHub Action that locks closed issues, pull requests and discussions after a period of inactivity
https://github.com/marketplace/actions/lock-threads
MIT License
313 stars 34 forks source link

[Feature Request] Option to disable notifications #6

Closed simurai closed 6 years ago

simurai commented 6 years ago

Would it be possible to add an option to disable sending a GitHub notification when an issue gets locked? Not sure if Probot supports that feature?

It's not a big issue for people that get GitHub notifications by email since they can create a filter. But for Web Notifications having all the locked issues show up again makes it quite noisy.

screen shot 2018-06-07 at 8 24 25 am

dessant commented 6 years ago

The notifications are created while posting comments, I think there is no good way for the comment author to prevent these notifications. The app can be configured to skip posting comments, I'd check in with @lee-dohm about it. Though they were in favor of explaining the reason of the lock and mentioning further actions that could be taken by users.

simurai commented 6 years ago

Thanks for the super 🚀 fast answer.

Ok, I see. It's the comment that actually sends the notifications. And comments without a notification are probably not allowed with the GitHub API.

Though they were in favor of explaining the reason of the lock and mentioning further actions that could be taken by users.

Yeah, I can see the benefit of adding a comment to explain why it got locked. 👍

dessant commented 6 years ago

A feature request could also be rised internally for ignoring notifications from certain users and apps, like on social networks. This is currently possible only by blocking users, but you can't block apps.

simurai commented 6 years ago

Or it could also be something that the Web notifications can improve. Like allowing to "mute" certain notifications, like you can mute tweets that contain certain words.

dessant commented 6 years ago

Yeah, such advanced filtering would be awesome. :dancer: