search

dessant / search-by-image

Browser extension for reverse image search, available for Chrome, Edge and Safari
https://apps.apple.com/us/app/search-by-image-for-safari/id1544552106
GNU General Public License v3.0
2.28k stars 200 forks source link

UI looks squished when in overflow menu #208

Closed dexeonify closed 2 years ago

dexeonify commented 2 years ago

System

Bug description

This is how the extension popup looks normally, when it's in Firefox toolbar: image and this is how it looks in the overflow menu, you can barely see the dropdown options: image

To add an extension into the Overflow menu, click the hamburger (☰) button > More tools > Customize toolbar, then drag "Search by Image" into the overflow menu. I usually put inactive extensions in the overflow menu for less clutter. But when I do need to use the popup, it's difficult to navigate in the tiny window.

So, is it possible to increase the size of the popup window? It doesn't have to be as big as the one in the Firefox toolbar, just bigger than it is now. Displaying scrollbar is fine.

Logs

No logs.

dessant commented 2 years ago

Thanks for the bug report! This must be triggered by a recent change, the extension popup was displayed correctly in the past. The bug can also be reproduced in Firefox 103.0.2.

dexeonify commented 2 years ago

Nope, I was able to reproduce it as far back as Firefox v95 using mozregression. I vividly remember encountering this issue when I first installed it but haven't been bothered to report it.

dessant commented 2 years ago

It is caused by a change in the extension, the document height is not set correctly.

dexeonify commented 2 years ago

Apparently this got fixed by Firefox's devs themselves not long after this issue is reported (14 days ago). Ref: bug 1783972 Screenshot: image

dessant commented 2 years ago

The latest Nightly looks great, though I've added a local fix too because we'll need to support the current version of Firefox.