search

dessant / search-by-image

Browser extension for reverse image search, available for Chrome, Edge and Safari
https://apps.apple.com/us/app/search-by-image-for-safari/id1544552106
GNU General Public License v3.0
2.28k stars 200 forks source link

Capture doesn't work anymore in isolated image tab #214

Closed neoOpus closed 1 year ago

neoOpus commented 2 years ago

Hi,

I would like to report that the capture that use to work on tabs with these URLs (extension://cnojnbdhbhnkbcieeekonklommdnndci/src/view/index.html?id=) and (data:image/png;base64,) doesn't work anymore, it was an excellent option to be able to circumvent some limitation I am having in facebook who turn the page white when I click on capture... so I open the images in new tabs via your extension then do a capture search from there...

I hope this can be easily fixed.

Thank you.

dessant commented 1 year ago

Regarding the white screen, this may be the cause: https://github.com/dessant/search-by-image/issues/232#issuecomment-1595817124

Searching from the context menu should work in extension pages, the menu item should be present when you right-click on an <img> element. Though an extension page could use different ways to show an image, and we have no way to extract that content.

The context menu item is indeed not shown for data URI pages, I think it was done because of an inconsistency across browsers, but let's look into it, the issue is tracked at https://github.com/dessant/search-by-image/issues/254.