search

dessant / search-by-image

Browser extension for reverse image search, available for Chrome, Edge and Safari
https://apps.apple.com/us/app/search-by-image-for-safari/id1544552106
GNU General Public License v3.0
2.28k stars 200 forks source link

Google Image Search Doesn't Work #249

Closed nu111 closed 1 year ago

nu111 commented 1 year ago

System

Bug description

  1. Have a image to test on
  2. Right click the image
  3. Click on Search by Image > Google
  4. Google Images "homepage" opens up, but no search is fired with the selected image

A video of the issue: https://github.com/dessant/search-by-image/assets/1246989/7fd962f2-bd75-48b4-b31c-e750e1c6dfcd

Similar issue on Firefox Android:

System

Bug description

  1. Have a image to test on
  2. Right click the image
  3. Click on Search by Image > Google
  4. Google Images opens up with a something that looks like a search using a broken image

A video of the issue: https://github.com/dessant/search-by-image/assets/1246989/6892a60f-21b9-4b82-8359-9ef7867024de

dessant commented 1 year ago

Version 4.6.0 is outdated and broken, could you test with the latest version of the extension (5.4.2)?

nu111 commented 1 year ago

Ok, just curious: isn't it expected that the addon will automatically update itself?

dessant commented 1 year ago

Yes, Firefox automatically updates extensions. The version you currently have was followed by an update that has requested a new permission (version 4.7.0), you've probably denied the permission request at the time so Firefox kept the old version installed.

The easiest would be to install it from AMO again, your settings should be preserved: https://addons.mozilla.org/en-US/firefox/addon/search_by_image/

nu111 commented 1 year ago

I confirm that with version 5.4.2 Google Image Search works fine.

The version you currently have was followed by an update that has requested a new permission (version 4.7.0), you've probably denied the permission request at the time so Firefox kept the old version installed.

Yes, could be!

For others reading:

on Firefox Desktop I had to manually check for updates Screenshot_20230528_180250

on Firefox Android I had to delete and reinstall the addon

Thanks for you help and for your time @dessant !