search

destradax / scratch

A simple scratch for Github's Atom
MIT License
7 stars 2 forks source link

Bug: Opening scratch raises Git error #15

Closed nholden closed 5 years ago

nholden commented 5 years ago

Summary

I noticed an error popping up in developer tools when I opened scratch. My guess it there's some conflict with the GitHub for Atom package.

Ideally, it would be great if the GitHub package would ignore scratch and show the open project's Git status instead. But finding any way to address the error message would be 👍.

Demo

git-error

Error message

Unable to locate git workspace root for /Users/nholden/.atom/scratch. Expected if /Users/nholden/.atom/scratch is not in a git repository. GitError: git rev-parse --show-toplevel in /Users/nholden/.atom exited with code 128
stdout: 
stderr: fatal: not a git repository (or any of the parent directories): .git

    at new GitError (/Applications/Atom.app/Contents/Resources/app/node_modules/github/lib/git-shell-out-strategy.js:123:24)
    at Promise (/Applications/Atom.app/Contents/Resources/app/node_modules/github/lib/git-shell-out-strategy.js:391:29)
    at <anonymous>
nholden commented 5 years ago

Hmm, I just noticed this happens when I open any file in a directory that doesn't have a Git repo, so I don't think this is specific to Scratch. Closing!