destruc7i0n / crafting

Website for generating Minecraft crafting recipe JSON files
https://crafting.thedestruc7i0n.ca/
MIT License
60 stars 8 forks source link

JSON recipe format changed again in 1.21.2/3 #36

Open vico93 opened 2 days ago

vico93 commented 2 days ago

Today i tried to make a simple Mud -> Packed Mud furnace (and blasting) recipe, and when i tried to load it via my custom datapack into 1.21.3 the following errors appeared on logs:

[20:06:07] [Worker-Main-2/ERROR]: Couldn't parse data file 'minecraft:packed_mud' from 'minecraft:recipe/packed_mud.json': DataResult.Error['Failed to parse either. First: Input does not contain a key [fabric:type]: MapLike[{"item":"minecraft:mud"}]; Second: Failed to parse either. First: Not a string: {"item":"minecraft:mud"}; Second: Failed to parse either. First: Not a json array: {"item":"minecraft:mud"}; Second: Not a string: {"item":"minecraft:mud"}']
[20:06:07] [Worker-Main-2/ERROR]: Couldn't parse data file 'vicocraft:packed_mud_from_blasting' from 'vicocraft:recipe/packed_mud_from_blasting.json': DataResult.Error['Failed to parse either. First: Input does not contain a key [fabric:type]: MapLike[{"item":"minecraft:mud"}]; Second: Failed to parse either. First: Not a string: {"item":"minecraft:mud"}; Second: Failed to parse either. First: Not a json array: {"item":"minecraft:mud"}; Second: Not a string: {"item":"minecraft:mud"}']

Reading through vanilla furnace/blasting recipes on mcasset and the misode's recipe generator, seems like the ingredient field for those kind of recipes (don't know about the others) changed for those latest versions.

Now it's like "ingredient": "minecraft:nether_quartz_ore" straight, instead of "ingredient": {"item": "minecraft:mud"} (with an item nested inside it). Perhaps @misode himself could help us understand what exactly Mojang changed on such recipes (i didnt find anyhing on the changelogs in either his site and Minecraft wiki about this aspect).

misode commented 2 days ago

It looks like the wiki is not updated yet. See the generators on my site or the breaking changes here: https://misode.github.io/versions/?id=1.21.2&tab=changelog&tags=breaking image

vico93 commented 2 days ago

Thank so much for the clarification!