search

destruc7i0n / shulker

A Discord to Vanilla Minecraft Chat Gateway
ISC License
135 stars 47 forks source link

Changed tail to make use of watch file. #57

Closed FeikoJoosten closed 4 years ago

FeikoJoosten commented 4 years ago

Fixed an issue where the log file required a manual refresh before the new lines were detected. Before I applied this fix I had to go into the folder of the log. Press the F5 button, before the file change was detected. Which in term would trigger the message sending from MC to Discord.

After I applied this fix, I no longer had to refresh the log folder and changes were being detected automatically.

destruc7i0n commented 4 years ago

Which OS were you on? Also, can the options variable be removed and the object passed to the constructor? I generally tend to steer clear from var in my code.

FeikoJoosten commented 4 years ago

Which OS were you on? Also, can the options variable be removed and the object passed to the constructor? I generally tend to steer clear from var in my code.

I'm running on Windows, I'm not able to test Linux unfortunately.

I've also fixed the coding style for you 😉.

destruc7i0n commented 4 years ago

I’ve tested it appears to work in Linux, doesn’t seem to be as efficient as the default watch command though I suppose it should not matter as much 👍