Closed bartelink closed 4 years ago
Lovely! Thank you for pushing through with this. One request: can you please add the upper bounds back on to the serilog dependency? It's a defensive habit to prevent breakages from major versions of dependent packages, and it narrows the search space for clients like paket.
I don't think it needs to be added for the fsharp.core dependency, because those are more and more being locked in by the SDK version you use.
FYI if you want to cross-validate, the smallest package I know of that applies this scheme is FsCodec. See https://github.com/jet/FsCodec/blob/master/src/FsCodec/FsCodec.fsproj
3.0 upper limit reinstated; good point (🤔 I should do some more of that)
Thanks for this 👍
One request: can you please add the upper bounds back on to the serilog dependency? It's a defensive habit to prevent breakages from major versions of dependent packages [...]
Unfortunately, you didn't achieve that goal with the code
<PackageReference Include="Serilog" Version="[2.0.0, 3.0.0)" />
because this notation intentially includes all prereleases of 3.0.0
, which might include breaking changes.
The only workaround that I know of is to instead use
<PackageReference Include="Serilog" Version="[2.0.0, 2.99]" />
or your favorite number of 9
s.
With the release of 1.1.0, I'm running into some conflicts when comparing with those imposed by using
Destructurama.FSharp
andDestructurama.FSharp.NetCore
(for onloookers: which is an externally managed short term package) of thev 1.0.14
rangeThis applies a standard convention I've used with success across other projects (originally from Enrico and Dave in https://github.com/jet/falanx), whereby:
This also includes some more debatable tidying stuff - please push back and I can remove them