search

desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
270 stars 42 forks source link

Desurium is using patched libraries (breakpad, wxWidgets) #115

Open karolherbst opened 12 years ago

karolherbst commented 12 years ago

issue for breakpad: #113

other interesting issues: #1 #16

I don't like the idea of using patched dependencies, because it can lead to problems in future releases of the dependencies, for example porting the patches to newer versions. Further it will speed up the whole build process, because it won't be necessary to build wxWidgets anymore (if 2.9 is installed). In addition it will lead to less memory usage, because desurium won't need its own instance of the libraries in RAM.

So, what should be done with these patches? And it is possible to use newer versions of these libraries?

Maybe the patches can be pushed upstream to wxWidgets and breakpad, but are there requests already?

links I found on wxWidgets: https://groups.google.com/group/wx-users/browse_thread/thread/818f301afc4484dc/955f2095a7162743?lnk=gst&q=desura#955f2095a7162743

a shorter patch for linux: http://pastebin.com/yd8xK51N

Jookia commented 12 years ago

While this is a problem, it doesn't affect how the software works. For now. It's a bad thing to do, but we should wait until everything settles.

karolherbst commented 12 years ago

some update about this:

successfully ported to patched wxWidgets 2.9.3 cef is based on chromium 14 and is still patched

karolherbst commented 12 years ago

look this commit:

https://github.com/karolherbst/Desurium/commit/9d605e85b5d4d1d828bbeb587fdc21ede48ab8a9

with this little "patch" I can build and run desura with system wxWidgets-2.9

as you see, we are using at line 192 this class

m_handlerPopup = new wxPopupWindowHandler(this);

so I think on Linux it would be easy to port to an unpatched wxWidgets.

I didn't tested how much stable this would be, but the biggest part of our patch is windows related.