desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
270 stars 42 forks source link

add FindPatch.cmake #475

Closed ghost closed 11 years ago

ghost commented 11 years ago

I've added FindPatch.cmake. This is only used when compiling under MSVC. CMake will exit with an error if patch.exe is not found (it'll search in system paths and the default installation directories of msysGit). I've also removed tortoiseGit as it's unneeded (msysGit provides both Git and patch.exe).

This pull needs to be tested on Linux/mingw as I made some changes that could affect these platforms.

karolherbst commented 11 years ago

I like most part of this request, but I am worried about using patch only from a git installation. It should be possible to build desurium on Windows without any git installation (because sometimes you will only download a versioned archive)

ghost commented 11 years ago

CMake will check %PATH% before checking in the git installation. The user is not affected by this change if they already have patch.exe in their path.

karolherbst commented 11 years ago

I think we should also check for patch on Linux, because of #243

ghost commented 11 years ago

It seems extremely unlikely that a developer would have all the necessary dependencies installed to compile Desurium except for patch.

karolherbst commented 11 years ago

it is still a direct dependency and we should check all of them.

FindPatch.cmake should work for UNIX based system as well, shouldn't it? We don't need to configure patch.sh as well, but we should fail if it isn't in PATH

ghost commented 11 years ago

Ok, change has been made.

karolherbst commented 11 years ago

seems fine to me now, thanks

karolherbst commented 11 years ago

last comment and then everything should be fine

ghost commented 11 years ago

Didn't even realise CMAKE_GEN_SRC_DIR existed. It should be all good now.

karolherbst commented 11 years ago

thanks