desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
270 stars 42 forks source link

desurium is launching urls in the external browser #531

Closed karolherbst closed 11 years ago

karolherbst commented 11 years ago

current master of desurium will open links in the system web browser if gnome-open is not installed on the system.

with this pull request https://github.com/lodle/Desurium/pull/530 it will also happen if xdg-open is not installed or the call fails (very unlikely)

karolherbst commented 11 years ago

I guess there is a check against the URL. But we should open every URL with this pattern "http[s]://.desura.com/" in desurium

karolherbst commented 11 years ago

I am sure the check against the url pattern is working correctly. The google custom search page on the other hand isn't directing to an URL matching this pattern, but to something like this: https://www.google.com/url?q=http://www.desura.com/*&[some_google_stuff]