search

desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
270 stars 42 forks source link

Fixed Boost copy_file error. #539

Closed Jookia closed 11 years ago

Jookia commented 11 years ago

This fixed #533. For real.

karolherbst commented 11 years ago

mhh, copy is doing implicit more than copy_file. If we want to make sure to copy a file, we should use copy_file. If we don't care about what type of "file" it is (symlink, file, directory), we can use copy

Jookia commented 11 years ago

Copy runs copy_file if it's a file. We could add a path type check if needed. I don't know of another way around it, but my fix shows that there's some weird linker stuff going on.

karolherbst commented 11 years ago

yes, I don't think we should "change behavior" here, but fix the linker issue directly. We could add Boost_FILESYSTEM_LIBRARY to the usercore and mcfcore library list, but I won't do that, because we don't use this interface there directly, but via another (static) dependency like util and util_fs. That's why I want to know where this linking error is comming from. But maybe we should move all of this static libs to shared libs aynway (to reduce time needed to find the cause of such errors and to reduce binary size)

karolherbst commented 11 years ago

I think we should not allow it to copy directories in a function name copyFile.

karolherbst commented 11 years ago

@Jookia how do you like this fix #542? It will pretend the same error with other methods using scoped enums in boost (copy_file is currently the only one, but you knows which guy wants to use one of these methods and wondering about a stupid linking error)

Jookia commented 11 years ago

That's a great fix.

karolherbst commented 11 years ago

So I am closing this request