Open TheSiege opened 11 years ago
which version of v8 is it?
I think we should remove all deprecated features, too.
)3.19.18.4(
Cant use Handle instead of Persistence as they are not the same thing.
Desurium 0.8 RC10 also fails to build on https://build.opensuse.org/package/rawlog/games/Desurium/openSUSE_13.1/i586 with libv8-3-3.20.0.1-2.1.3
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp: In member function 'void ScriptCoreInternal::init()':
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:70:77: warning: 'static v8::Local<v8::FunctionTemplate> v8::FunctionTemplate::New(v8::InvocationCallback, v8::Handle<v8::Value>, v8::Handle<v8::Signature>, int)' is deprecated (declared at /usr/include/v8.h:3263) [-Wdeprecated-declarations]
[ 203s] global->Set(v8::String::New("Warning"), v8::FunctionTemplate::New(JSWarning));
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:71:73: warning: 'static v8::Local<v8::FunctionTemplate> v8::FunctionTemplate::New(v8::InvocationCallback, v8::Handle<v8::Value>, v8::Handle<v8::Signature>, int)' is deprecated (declared at /usr/include/v8.h:3263) [-Wdeprecated-declarations]
[ 203s] global->Set(v8::String::New("Debug"), v8::FunctionTemplate::New(JSDebug));
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:73:85: warning: 'static v8::Persistent<v8::Context> v8::Context::New(v8::ExtensionConfiguration*, v8::Handle<v8::ObjectTemplate>, v8::Handle<v8::Value>)' is deprecated (declared at /usr/include/v8.h:4921) [-Wdeprecated-declarations]
[ 203s] v8::Persistent<v8::Context> context = v8::Context::New(RegisterJSBindings(), global);
[ 203s] ^
[ 203s] In file included from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.h:26:0,
[ 203s] from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:21:
[ 203s] /usr/include/v8.h:751:3: error: 'v8::Persistent<T>::Persistent(const v8::Persistent<T>&) [with T = v8::Context]' is private
[ 203s] V8_INLINE(Persistent(const Persistent& that)) : val_(that.val_) {}
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:73:85: error: within this context
[ 203s] v8::Persistent<v8::Context> context = v8::Context::New(RegisterJSBindings(), global);
[ 203s] ^
[ 203s] In file included from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.h:26:0,
[ 203s] from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:21:
[ 203s] /usr/include/v8.h:753:3: error: 'v8::Persistent<T>& v8::Persistent<T>::operator=(const v8::Persistent<T>&) [with T = v8::Context]' is private
[ 203s] V8_INLINE(Persistent& operator=(const Persistent& that)) { // NOLINT
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:74:14: error: within this context
[ 203s] m_v8Context = context;
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp: In member function 'void ScriptCoreInternal::runString(const char*)':
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:93:46: error: no matching function for call to 'v8::Context::Scope::Scope(v8::Persistent<v8::Context>&)'
[ 203s] v8::Context::Scope context_scope(m_v8Context);
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:93:46: note: candidates are:
[ 203s] In file included from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.h:26:0,
[ 203s] from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:21:
[ 203s] /usr/include/v8.h:5042:5: note: v8::Context::Scope::Scope(v8::Isolate*, v8::Persistent<v8::Context>&)
[ 203s] V8_INLINE(Scope(Isolate* isolate, Persistent<Context>& context)) // NOLINT
[ 203s] ^
[ 203s] /usr/include/v8.h:5042:5: note: candidate expects 2 arguments, 1 provided
[ 203s] /usr/include/v8.h:5038:14: note: v8::Context::Scope::Scope(v8::Handle<v8::Context>)
[ 203s] explicit V8_INLINE(Scope(Handle<Context> context)) : context_(context) {
[ 203s] ^
[ 203s] /usr/include/v8.h:5038:14: note: no known conversion for argument 1 from 'v8::Persistent<v8::Context>' to 'v8::Handle<v8::Context>'
[ 203s] /usr/include/v8.h:5036:9: note: constexpr v8::Context::Scope::Scope(const v8::Context::Scope&)
[ 203s] class Scope {
[ 203s] ^
[ 203s] /usr/include/v8.h:5036:9: note: no known conversion for argument 1 from 'v8::Persistent<v8::Context>' to 'const v8::Context::Scope&'
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp: In member function 'void ScriptCoreInternal::runScript(const char*, const char*, uint32_t)':
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:122:46: error: no matching function for call to 'v8::Context::Scope::Scope(v8::Persistent<v8::Context>&)'
[ 203s] v8::Context::Scope context_scope(m_v8Context);
[ 203s] ^
[ 203s] /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:122:46: note: candidates are:
[ 203s] In file included from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.h:26:0,
[ 203s] from /home/abuild/rpmbuild/BUILD/Desurium-0.8.0_rc10/src/static/scriptengine/code/ScriptCoreInternal.cpp:21:
[ 203s] /usr/include/v8.h:5042:5: note: v8::Context::Scope::Scope(v8::Isolate*, v8::Persistent<v8::Context>&)
[ 203s] V8_INLINE(Scope(Isolate* isolate, Persistent<Context>& context)) // NOLINT
[ 203s] ^
[ 203s] /usr/include/v8.h:5042:5: note: candidate expects 2 arguments, 1 provided
[ 203s] /usr/include/v8.h:5038:14: note: v8::Context::Scope::Scope(v8::Handle<v8::Context>)
[ 203s] explicit V8_INLINE(Scope(Handle<Context> context)) : context_(context) {
[ 203s] ^
[ 203s] /usr/include/v8.h:5038:14: note: no known conversion for argument 1 from 'v8::Persistent<v8::Context>' to 'v8::Handle<v8::Context>'
[ 203s] /usr/include/v8.h:5036:9: note: constexpr v8::Context::Scope::Scope(const v8::Context::Scope&)
[ 203s] class Scope {
[ 203s] ^
[ 203s] /usr/include/v8.h:5036:9: note: no known conversion for argument 1 from 'v8::Persistent<v8::Context>' to 'const v8::Context::Scope&'
[ 203s] cc1: warning: command line option '-fpermissive' is valid for C++/ObjC++ but not for C [enabled by default]
[ 203s] make[2]: *** [src/static/scriptengine/CMakeFiles/scriptengine.dir/code/ScriptCoreInternal.cpp.o] Error 1
[ 203s] make[1]: *** [src/static/scriptengine/CMakeFiles/scriptengine.dir/all] Error 2