search

desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
269 stars 44 forks source link

static/scriptengine: use Handle instead of Persistence #570

Closed karolherbst closed 11 years ago

karolherbst commented 11 years ago

fixes #569

karolherbst commented 11 years ago

this has a compile error with older versions of v8, my bad :(

TheSiege commented 11 years ago

confirmed

TheSiege commented 11 years ago

so what do we do about it?

karolherbst commented 11 years ago

either I check against the v8 version in source (#ifdef) or I find a way how to convert a v8::Persistent into a v8::Handle

karolherbst commented 11 years ago

but I think the first one isn't possible, because they don't provide any #defines for it

karolherbst commented 11 years ago

does this error occur without this patch, too?

TheSiege commented 11 years ago

i got two white bars in the game symbols apart from that works like a charm