desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
269 stars 44 forks source link

Bug491 #575

Closed Smilex closed 10 years ago

Smilex commented 11 years ago

Replaces tinyxml with tinyxml2.

karolherbst commented 11 years ago

some comments without a look into the changed files:

Smilex commented 11 years ago

Did I get it right this time?

karolherbst commented 11 years ago

this little diff should be applied on this branch. It is only some documentation, install_deps.sh and travis stuff: http://bpaste.net/show/114420/

karolherbst commented 11 years ago

as I found out, travis is ubuntu 12.04 so it doesn't have a tinyxml2 dev package. So we have to remove it from the apt-get install command and remove "-DFORCE_SYS_DEPS=on" from the cmake call.

In addition to that, there are some tiny little things in the diff, I will make comments there

karolherbst commented 11 years ago

I went through all the changes an I might found everything, but I will take a new look after the corrections

karolherbst commented 10 years ago

I think I will clean up this request and merge it via cli (without removing your author tags of course)

karolherbst commented 10 years ago

it would be nice if you would update your branch with my cleaned up commits found here: https://github.com/karolherbst/Desurium/commits/bug491

karolherbst commented 10 years ago

closed due newer pull request