Closed karolherbst closed 10 years ago
Does this work on Linux?
travis-ci doesn't find any compile errors and I tried it out on Linux once (before the commit clean up).
I am pretty sure it will work, because most of the changes are in win32 only parts.
But here is a list of commits, which are effecting Linux parts, too.
I will do some deep testing anyway, I just wanted to make this request, so others can try it out and test, too
okay, got one compile error in cef:
cef/libcef/webview_host.cc: At global scope:
cef/libcef/webview_host.cc:7:1: error: prototype for ‘WebViewHost::WebViewHost(BrowserWebViewDelegate*)’ does not match any in class ‘WebViewHost’
WebViewHost::WebViewHost(BrowserWebViewDelegate* delegate)
^
In file included from cef/libcef/webview_host.cc:5:0:
cef/libcef/webview_host.h:26:7: error: candidates are: WebViewHost::WebViewHost(const WebViewHost&)
class WebViewHost : public WebWidgetHost {
^
cef/libcef/webview_host.h:26:7: error: WebViewHost::WebViewHost()
I fixed the commit and it should work now on both Linux and Windows
I'm going to merge, even if it breaks things as I think it just needs to be gotten over with. Also documentation needs to be worked on.
The windows cef build is a bit borked, but for developing a pre compiled cef dll is more than enough. It isn't impossible to build cef on windows, there are only some modifications needed for it.
Anyway, now we can start to seperate cef from desura_cef and split the repository.
this pull request add all stuff needed to build desurium on windows systems
There are still some issues left with the CEF build:
Except of this issues, desurium seems to run just fine. I've tested installing/running games, browser through the store and view flash videos. H.264 won't work with the chromium 15 code base, because it does not support building ffmpeg and we can only download ffmpeg dlls without prop. codec support.
this pull request fixes #106 and fixes #583. It also fixes #329 for windows, it was already for Linux.