search

desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
270 stars 42 forks source link

Fixed issue with desura corrupting downloads #615 #616

Closed lodle closed 10 years ago

Jookia commented 11 years ago

@karolherbst This breaks on GCC (Travis CI at least), due to the override keyword. Are some flags not set?

karolherbst commented 11 years ago

also you should try to reorder the commits with git rebase. So first this #define override thing, then the actual fixes. This will prevent some issues while rebasing bugs. We should try to keep every commit compileable on every platform and the fix for this isn't that hard.

karolherbst commented 11 years ago

We should wait with this commit until gtest got merged

karolherbst commented 10 years ago

cleaned up branch: https://github.com/karolherbst/Desurium/commits/bugfix615

karolherbst commented 10 years ago

@lodle what do you think? https://github.com/karolherbst/Desurium/commit/cbecddf8b3fe903de00ed8ae2efbab54e8d76fcc

lodle commented 10 years ago

Looks good karolherbst. Merge when ready