desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
268 stars 44 forks source link

Updated release build to build with debugging information #630 #631

Closed lodle closed 10 years ago

karolherbst commented 10 years ago

We should rework the DEBUG option anyway, I just have to figure out how to deal with external projects on windows with the cmake internal build types

lodle commented 10 years ago

This is for release builds though. Need the pdb files to debug crash dumps

karolherbst commented 10 years ago

Yeah, I know. This path can be used for creating releases, but I would like to have a more cmake aware solution. There should be a way of telling cmake when do build External builds in which way without having too much pain.

karolherbst commented 10 years ago

any updates here?

lodle commented 10 years ago

Im not sure what you want. This is the cmake solution for this.

karolherbst commented 10 years ago

I wanted to know what you ideas are about using RelWithDebInfo only for official builds

lodle commented 10 years ago

Oh can do that. Is there an issue with having it for non official builds? Debug info is always useful

karolherbst commented 10 years ago

yeah, but distributions want to set the flags on their own anyway