search

desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
268 stars 44 forks source link

Fixed boost throwing an exception parsing date string #634

Closed lodle closed 10 years ago

karolherbst commented 10 years ago

I am fine with this, but we should try to be more strict about proper commit messages. There are some changes wich belongs in the first commit, but are in the second one.

We should talk about QA and what is required before commits get merged.

lodle commented 10 years ago

Looking back the first commit is not needed at all. Im open to ideas but it doesnt bother me that much that a bit of noise gets into the commits.

karolherbst commented 10 years ago

yeah, that's the reason why we should talk about it, so we have an objective set of rules we can al stick to

karolherbst commented 10 years ago

Is there a way how to reproduce this bug, so I can check this?

lodle commented 10 years ago

Look at the unit tests?

karolherbst commented 10 years ago

yeah, :(

lodle commented 10 years ago

With out this fix try installing a game. It should fail on setting the date stamp on the file every time and spam the console.

karolherbst commented 10 years ago

ahh, I actually saw this I think

lodle commented 10 years ago

And you sat there and did nothing :D

karolherbst commented 10 years ago

This was some days ago, actually after this request :D

karolherbst commented 10 years ago

@lodle cleaned up branch is here: https://github.com/karolherbst/Desurium/tree/bugfix633

karolherbst commented 10 years ago

merged in de8644fa53a7998dcc7f0a569e225dec2c39abab