desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
268 stars 44 forks source link

Added control + c (copy) to message dialogs to copy text #373 #643

Closed lodle closed 10 years ago

karolherbst commented 10 years ago

Shouldn't that be handled automatically? I am worried, that we are doing so much on our own and force specific key combinations, which seems to be standard, but specially on Linux you are able to rebind nrearly everything.

Isn't there a way to add the copy shortcut without knowing which it is?

lodle commented 10 years ago

this is only for error dialog's and control + c is very well known. Im not to worried about custom bindings.

karolherbst commented 10 years ago

ask the guys who are using dvorak ;) I just would loke to know if there is any other possibility as checking against WXK_CONTROL_C. If there is no, I will be fine with that.

lodle commented 10 years ago

From a quick google, no

Jookia commented 10 years ago

Maybe we should open a new issue for compatibility with keyboard shortcuts and push that back to another time.

karolherbst commented 10 years ago

I will test this later

karolherbst commented 10 years ago

cleaned up branch: https://github.com/karolherbst/Desurium/commits/bugfix373

lodle commented 10 years ago

moved to https://github.com/desura/Desurium/pull/682