desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
268 stars 44 forks source link

Use Wx3.0 instead of bundled 2.9.3 if present in the system. #653

Open karolherbst opened 10 years ago

karolherbst commented 10 years ago

original request by @makson96 #652

wxWidgets developers manage to point out fixes for the breaks in compatibility with wxWidgets 2.9.5. http://trac.wxwidgets.org/ticket/15529

With this pull request if wxWidgets 3.0 is present in the system, than it will be used instead of bundled 2.9.3. On Linux it works great on wxWidgets 3.0.0-r1 without pink dots regression: #288 and still provide backward compatibility with wxWidgets 2.9.3.

I publish this pull request for testing purposes. I hope that when wxWidgets 3.0 comes out it will be working great with this changes and then we can merge it to the master.

Jookia commented 10 years ago

Works well for me.

karolherbst commented 10 years ago

did you also notice compile time improvements with embedded wxgtk?

karolherbst commented 10 years ago

I have removed the dependency for richtext on system wxWidgets. Is anybody able to check if desurium compiles with a system installed wxWidgets-2.9.5+ ?

karolherbst commented 10 years ago

I also brought back compatibility with older wxWidgets then 2.9.5, because some package repositories are still at 2.9.4 max and we do't want to break compilation there.

makson96 commented 10 years ago

I will check this on system wxWidgets 3.0.0-r1 (Gtk+2) later today.

karolherbst commented 10 years ago

@makson96 any updates?

makson96 commented 10 years ago

Well, I did not manage to test it yesterday. I will do that, when I will have some free time to play with Desurium.

karolherbst commented 10 years ago

okay, thanks

karolherbst commented 10 years ago

for reference: http://www.cmake.org/Bug/view.php?id=10694

makson96 commented 10 years ago

This branch works without any noticeable regression on system installed wxWidgets 3.0.0-r1.

karolherbst commented 10 years ago

I will test this on windows

karolherbst commented 10 years ago

windows doesn't seems to work with it

makson96 commented 10 years ago

Could you please move now to wx 3.0-rc2?

makson96 commented 10 years ago

We should update now to wx 3.0 final.

lodle commented 10 years ago

ill give this a go start of next year