desura / Desurium

Free online games platform (juegos gratis), with an open source client. LGPL repo for Desura client. Potentially out of date. See https://github.com/desura/desura-app for newest (LGPL) client.
https://www.desura.com/es
GNU General Public License v3.0
268 stars 44 forks source link

Typo in Buildv8.cmake #663

Closed nat-goodspeed closed 10 years ago

nat-goodspeed commented 10 years ago

Make fails with a reference to libv8.{V8_LIB_SUFFIX}:

index bae0095..501635d 100644
--- a/cmake/modules/Buildv8.cmake
+++ b/cmake/modules/Buildv8.cmake
@@ -64,9 +64,9 @@ if(WIN32)
   endif()
 else()
   if(DEBUG_V8)
-    set(V8_LIBRARIES "${V8_INSTALL_DIR}/out/out/Debug/lib.target/libv8.{V8_LIB_SUFFIX}")
+    set(V8_LIBRARIES "${V8_INSTALL_DIR}/out/out/Debug/lib.target/libv8.${V8_LIB_SUFFIX}")
   else()
-    set(V8_LIBRARIES "${V8_INSTALL_DIR}/out/out/Release/lib.target/libv8.{V8_LIB_SUFFIX}")
+    set(V8_LIBRARIES "${V8_INSTALL_DIR}/out/out/Release/lib.target/libv8.${V8_LIB_SUFFIX}")
   endif()
   install(FILES ${V8_LIBRARIES}
           DESTINATION ${LIB_INSTALL_DIR})
karolherbst commented 10 years ago

it is part of my apple2 branch, so I just close this issue and fix it on my branch

lodle commented 10 years ago

I had this change locally when i was compiling on mac