search

desura / desura-app

Free online games platform, with an open source client. In these scenarios, Desura's free online games are the perfect solution. These games don't require a high-powered computer or lengthy installation processes.
https://www.desura.com/
Other
121 stars 31 forks source link

kill FORCE_SYS_DEPS switch #733

Open makson96 opened 10 years ago

makson96 commented 10 years ago

I put some thoughts about some switches and I find them counter-intuitive. Even if FORCE_SYS_DEPS=OFF, system deps will be used if found and build (if possible) if not found.

I think we can safely remove this switch and leave only FORCE_BUNDLED_WXGTK or create other FORCEBUNDLED for problematic libs (for example #725 ). We can also change the name of the switch from FORCE_BUNDLED_WXGTK to simply BUNDLE_WXGTK.

Also I don't feel comfortable with 2 CEF switches. What would be expected outcome of such a combination: BUILD_CEF=OFF BUILD_ONLY_CEF=ON? Maybe we should handle it in some more elegant way?

TheSiege commented 10 years ago

if it still gives me an error when for example BUNDLE_WXGTK=OFF and wxgtk is not found then I like the idea

makson96 commented 10 years ago

@lodle any comment? Do I have a blessing to play with it? Any thoughts about cef switches?

lodle commented 10 years ago

BUILD_CEF and BUILD_ONLY_CEF are used for two diff things.

you can build desura with out cef (which i do often on windows) which is controlled by the first switch, the second is to only build cef.

With the build vars, i do agree that you should have one per third party dep but also i think there should be one to turn them all on if possible to use.