desword / android-apktool

Automatically exported from code.google.com/p/android-apktool
Other
1 stars 0 forks source link

malformed html styles #602

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
There does seem to be problems with this.

If a string like

foo


It used to crash.

Now it comes out as (with: 
https://github.com/iBotPeaches/Apktool/commit/d90bea10ce33abadc37ec38f1a48f4557c
a568af )

foo


Missing the trailing slash. I got a commit out that fixes the crashes to 
prevent apktool from being abused from this problem, but I'll have to look into 
the HTML function more in depth and write a whole class of unit-tests for this 
so that we don't strip the trailing ; and fix the crash.

The bug with lengths being read as short max has been fixed: 
https://github.com/iBotPeaches/Apktool/commit/ca314b9aaed6a6bac28dbb7d4c7b995728
eaac81

Original issue reported on code.google.com by connor.tumbleson on 10 Feb 2014 at 4:03

GoogleCodeExporter commented 9 years ago

Original comment by connor.tumbleson on 19 Mar 2014 at 9:53