desy-ml / cheetah

Fast and differentiable particle accelerator optics simulation for reinforcement learning and optimisation applications.
https://cheetah-accelerator.readthedocs.io
GNU General Public License v3.0
27 stars 12 forks source link

Update pre-commit config #148

Closed jank324 closed 2 months ago

jank324 commented 2 months ago

Description

Update alle versions in .pre-commit-config.yaml.

Motivation and Context

Closes #147.

Types of changes

Checklist

Note: We are using a maximum length of 88 characters per line

jank324 commented 2 months ago

So @cr-xu, I'm not sure if this is a satisfactory solution. Basically, the versions of rev are not allowed to be dynamic. For now, I've updated them. We would have to keep updating them whenever a version mismatch leads to a mismatch between the pre-commit hook and the respective GitHub Action. This would be a little work ... but the mismatch would inherently alert us when it needs doing.

cr-xu commented 2 months ago

okay it makes sense. I think breaking changes in these linting tools happen only more or less on a yearly basis so it wouldn't be so annoying.