Fix a missing sign in the cavity tracking method (v0.6.3 was not affected. This was introduced somewhere in the batched execution upgrade #116, but remains unidentified as the test was still passing with some rtol)
Remove large rtols in the related test as they are no longer required.
Add an additional test identifying the issue with non-zero RF phase
Description
Motivation and Context
[ ] I have raised an issue to propose this change (required for new features and bug fixes)
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
Checklist
[x] I have updated the changelog accordingly (required).
[ ] My change requires a change to the documentation.
[x] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.
[x] I have reformatted the code and checked that formatting passes (required).
[x] I have have fixed all issues found by flake8 (required).
[x] I have ensured that all pytest tests pass (required).
[ ] I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
[ ] I have checked that the documentation builds (required).
Note: We are using a maximum length of 88 characters per line
Description
Motivation and Context
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line