Open jank324 opened 2 weeks ago
@cr-xu didn't you look into this before?
On a second thought, maybe requiring the contributors to install pre-commit
is a better solution
So... pros and cons of using GH Actions to reformat and commit:
Pro:
Con:
The cons seem to clearly outweigh the pros here. I think we should leave it as is, and maybe (a) make the contribution guidelines more comprehensive and (b) add a checkmark to PRs "I have read the contribution guidelines".
Should we set up
black
to automatically format the code on commits or pushes? Right now it only checks and complains when the code is not formatted correctly.