search

desy-ml / cheetah

Fast and differentiable particle accelerator optics simulation for reinforcement learning and optimisation applications.
https://cheetah-accelerator.readthedocs.io
GNU General Public License v3.0
28 stars 13 forks source link

Establish testing test_pycharm.py #34

Closed FelixTheilen closed 1 year ago

FelixTheilen commented 1 year ago

Creates a file which implements the testfile test.ipynb via pytest.

The following abilities are tested: -import a ParameterBeam using .from_parameters -import a ParticleBeam using .from_parameters -using .transformed_to

jank324 commented 1 year ago

@FelixTheilen This pull request looks really good at first glance. The only thing I'm not sure about is the file name. The name should give some indication on what is tested by the tests in the file, so something like test_beam_creation.py (just an idea) would make more sense.

jank324 commented 1 year ago

Aside from that we just need to make sure all tests run (not just on @FelixTheilen's machine.

jank324 commented 1 year ago

@FelixTheilen Can you merge the most recent version of the master branch into this pull request? I've changed some things about the automatic testing that GitHub does, but it doesn't show up on your pull requests yet.

I think you can do this for this pull request first. If that gets the testing to show up properly, you can repeat it for the others as well.