desy-ml / cheetah

Fast and differentiable particle accelerator optics simulation for reinforcement learning and optimisation applications.
https://cheetah-accelerator.readthedocs.io
GNU General Public License v3.0
28 stars 13 forks source link

Conversion Error from Ocelot Monitor to Cheetah Screen #37

Closed FelixTheilen closed 1 year ago

FelixTheilen commented 1 year ago

The function ocelot2cheetah does not correctly convert Monitors written in Ocelot to Cheetah Screens. In the documentation it is said, that ocelot.Monitor elements containing the string "SCR" in their id are converted to Screen elements. Despite this the code is searching for the String "BSC". Ideally the code should be changed in a way that older code containing the "BSC" identifier as well as newer code containing the "SCR" identifier can both be processed. The documentaion should also be modified to explain this.