Fix `__eq__` check for Segment

desy-ml / cheetah

Fast and differentiable particle accelerator optics simulation for reinforcement learning and optimisation applications.

https://cheetah-accelerator.readthedocs.io

GNU General Public License v3.0

28 stars 13 forks source link

Closed cr-xu closed 1 year ago

cr-xu commented 1 year ago

Problem: the default __eq__ only checks for equality in attributes. For Segment this behavior is not ideal.

Changes:

Overwrite the__eq__ for Segment so that it checks that every element in the segment is identical.
Updated the Ocelot lattice file for unique element id
Updated the corresponding Cheetah file
Updated test files accordingly.

cr-xu commented 1 year ago

Sorry I forgot to mark #56 as still a work in progress 🙃

jank324 commented 1 year ago

Ups ... 🙃