desy-multimessenger / nuztf

Central repository for scripts handling ZTF Target of Opportunity requests using AMPEL. This includes neutrino, GRB and GW events.
MIT License
1 stars 0 forks source link

Rework cache #313

Closed robertdstein closed 1 year ago

robertdstein commented 1 year ago

This PR unifies the cache structure, and removes some existing redundancy. It introduces a central paths.py to contain directories. The various files are saved to caches based either on the name of the parent event (e.g for candidate PDFs), OR the name of the ZTF source if it is event-agnostic (e.g crossmatching).

It updates the crossmatching for WISE, to display the nearest source if there are multiple matches.

It adds some scattered docstrings introduced as I went though the code.

It comments out the buggy GRB name code (#312), and associated test.

It also updates the pre-commit to use isort (which sorts imports).

coveralls commented 1 year ago

Coverage Status

Coverage: 69.992% (+0.02%) from 69.974% when pulling c3288f3a4bd8e9827df4d5167a9e4f80b0568a44 on minobssummary into ff50aa6949031a57cd419b2329d3e27bede403fb on main.