search

deta / space-docs

Documentation and guides for Deta Space
https://deta.space/docs
Other
42 stars 15 forks source link

After installing on Linux, start a new shell #142

Closed peter-lyons-kehl closed 1 year ago

peter-lyons-kehl commented 1 year ago

Hi at Deta.

  1. Local machine: x64 Linux: current Manjaro (stable Arch), pretty standard, bash in standard GNOME Terminal app.
  2. Successfully installed Following https://deta.space/docs/en/build/new-apps#installing-the-space-cli > "Linux" tab (from within bash in GNOME Terminal).
  3. Problem: Can't run space login (or space anything-here) in that very same bash. space was not on $PATH yet. I did NOT have to close & restart whole Terminal, neither to open any new Terminal window. I did work in a new Terminal tab (even within that same Terminal window).

Please update https://deta.space/docs/en/build/new-apps#installing-the-space-cli to reflect that.

(We most likely don't want people to re-apply ~/.bashrc like source ~/.bashrc, as that may mess up aliases...) Thank you in advance.

abdelhai commented 1 year ago

thanks! feel free to send a pr as well if you feel like it. @MaximilianHeidenreich: could we add some kind of info box saying, if you get "space not found" to restart/open a new shell? i think in the standard case, it should work. might be worth testing.

MaximilianHeidenreich commented 1 year ago

@abdelhai We could definitely add an info box inside the docs, but I think we can solve this issue better by just adding to the PATH variable manually after a successful installation. This will make space available inside the current shell instantly.

-> Update: Talked to aavash about this, but my proposed solution does actually not work. We do already tell users to run space commands in a new shell after installing the CLI, though. I'll add a more explicit info box to the docs.

MaximilianHeidenreich commented 1 year ago

Closed as we have added additional information inside the installation section of the CLI docs. See #170 for reference.