search

detailyang / pre-commit-shell

:beers: pre commit wrapper shellcheck
MIT License
43 stars 18 forks source link

Running `pre-commit autoupdate` downgrade the version #12

Open fauust opened 4 years ago

fauust commented 4 years ago

Hi!

.venv ❯ cat .pre-commit-config.yaml
- repo: https://github.com/detailyang/pre-commit-shell
    rev: v1.0.6
    hooks:
      - id: shell-lint
        name: Check for shell syntax (shellcheck)
        args: ["-x"]
.venv ❯ pre-commit autoupdate
Updating https://github.com/detailyang/pre-commit-shell ... updating v1.0.6 -> 1.0.5.
chrisgilmerproj commented 2 years ago

I am also experiencing this issue. Because the version checker things that versions without a v come after versions with a v it will always downgrade v1.0.6 to 1.0.5. Can we ask that either all the tags get updated to include a v or that the repo goes back to using versions without a v?

chrisgilmerproj commented 2 years ago

I have opened a bug report here: https://github.com/pre-commit/pre-commit/issues/2364

smussie commented 1 month ago

Hi, 2024 and I got the same issue, but in view of 1.0.5 tag being released after the v1.0.6, it shouldn't be a downgrade but some problem in tagging.