search

detekt / detekt-intellij-plugin

detekt plugin for IntelliJ
https://plugins.jetbrains.com/plugin/10761-detekt
Apache License 2.0
297 stars 39 forks source link

Make paths sortable, add migration #460

Closed rock3r closed 1 year ago

rock3r commented 1 year ago

This fixes #385 — a word of caution though, I have only had time to test this cursorily. I am terribly sorry that I don't have more time to work on this right now, but it's been dragging for long enough I stole a couple hours from other stuff this weekend to at least get most of it done. I'm confident if any minor issues are found, the maintainers can step in for fixes (this was a small and straightforward fix to begin with).

rock3r commented 1 year ago

@arturbosch can I get a review?

arturbosch commented 1 year ago

Works greatly, will release 1.22.2 today, thanks 👍🏼

rock3r commented 1 year ago

Happy to hear it works well. Sorry it took this much time to implement this, but I've been very scarce on spare time recently

stenzengel commented 1 year ago

@arturbosch Could you please release 1.22.2 for Android Studio? When trying to install the normal plugin in my current Android Studio installation from disk, I get the following error Plugin 'Detekt' (version '1.22.2') is not compatible with the current version of the IDE, because it requires build 221.4842.29 or newer but the current build is AI-212.5712.43

rock3r commented 1 year ago

@stenzengel it looks like you're using a version of AS that is more than a year old... Can you upgrade to the latest stable? That one is compatible

arturbosch commented 1 year ago

@arturbosch Could you please release 1.22.2 for Android Studio? When trying to install the normal plugin in my current Android Studio installation from disk, I get the following error Plugin 'Detekt' (version '1.22.2') is not compatible with the current version of the IDE, because it requires build 221.4842.29 or newer but the current build is AI-212.5712.43

Yes, as @rock3r mentioned AS 2022.1.1 should be out and it works with 1.22.2. I would like to drop support for the android specific version as soon as possible. Are there any reasons you need to stay at the old one ?

stenzengel commented 1 year ago

@arturbosch Unfortunately, I cannot upgrade to the latest stable version, because version 2021.2.1 Patch 1 from May last year is currently the latest version available in my corporate environment. I will try to trigger IT department for an update. If it is not too much work for you, a release of the Android specific version of this plugin would be helpful.

arturbosch commented 1 year ago

@arturbosch Unfortunately, I cannot upgrade to the latest stable version, because version 2021.2.1 Patch 1 from May last year is currently the latest version available in my corporate environment. I will try to trigger IT department for an update. If it is not too much work for you, a release of the Android specific version of this plugin would be helpful.

I just published 1.22.2-android. It should be up in 1-2 days after JetBrains review.

stenzengel commented 1 year ago

Many thanks.