Closed MaximSysoev closed 3 weeks ago
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 84.70%. Comparing base (
19b1784
) to head (787d8c6
).
Files | Patch % | Lines |
---|---|---|
...osch/detekt/core/baseline/BaselineResultMapping.kt | 87.50% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice cleanup :)
Cool, thanks!
Could you merge it? I don't have write access.
Could you merge it? I don't have write access.
Generally we wait around ~24h to allow other maintainers to also chime in (specifically @BraisGabin as he originally requested this change). We can merge it later today 👍
Could you merge it? I don't have write access.
Generally we wait around ~24h to allow other maintainers to also chime in (specifically @BraisGabin as he originally requested this change). We can merge it later today 👍
Ok, I see :) Thank you :) 👍
Merge
BaselineResultMapping
BaselineFilteredResult
andBaselineFacade
intoBaselineResultMapping
and also merge corresponding test specs as described here #6882.Close #6882