detekt / detekt

Static code analysis for Kotlin
https://detekt.dev
Apache License 2.0
6.07k stars 751 forks source link

Merge logic of baseline result mapping into one class. #7208

Closed MaximSysoev closed 3 weeks ago

MaximSysoev commented 3 weeks ago

Merge BaselineResultMapping BaselineFilteredResult and BaselineFacade into BaselineResultMapping and also merge corresponding test specs as described here #6882.

Close #6882

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.70%. Comparing base (19b1784) to head (787d8c6).

Files Patch % Lines
...osch/detekt/core/baseline/BaselineResultMapping.kt 87.50% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7208 +/- ## ============================================ - Coverage 84.71% 84.70% -0.01% + Complexity 3984 3981 -3 ============================================ Files 579 577 -2 Lines 12153 12148 -5 Branches 2494 2493 -1 ============================================ - Hits 10295 10290 -5 Misses 625 625 Partials 1233 1233 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MaximSysoev commented 3 weeks ago

Nice cleanup :)

Cool, thanks!

Could you merge it? I don't have write access.

cortinico commented 3 weeks ago

Could you merge it? I don't have write access.

Generally we wait around ~24h to allow other maintainers to also chime in (specifically @BraisGabin as he originally requested this change). We can merge it later today 👍

MaximSysoev commented 3 weeks ago

Could you merge it? I don't have write access.

Generally we wait around ~24h to allow other maintainers to also chime in (specifically @BraisGabin as he originally requested this change). We can merge it later today 👍

Ok, I see :) Thank you :) 👍

detekt-ci commented 3 weeks ago
Warnings
:warning: This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by :no_entry_sign: dangerJS against 787d8c6a575415ec60b86dbc87b20ca8553d144b