search

detekt / detekt

Static code analysis for Kotlin
https://detekt.dev
Apache License 2.0
6.07k stars 751 forks source link

Move helper functions to test fixtures #7211

Closed 3flex closed 3 weeks ago

3flex commented 3 weeks ago

These were only called from test code so can be removed from the public API.

I'd hesitate to call this a breaking change though it technically is, if we don't use it in production code I can't see why third party code would need to either.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.70%. Comparing base (8e9c993) to head (154d4e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7211 +/- ## ============================================ - Coverage 84.71% 84.70% -0.01% Complexity 3986 3986 ============================================ Files 580 580 Lines 12162 12156 -6 Branches 2496 2496 ============================================ - Hits 10303 10297 -6 Misses 625 625 Partials 1234 1234 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cortinico commented 3 weeks ago

I'd hesitate to call this a breaking change though it technically is, if we don't use it in production code I can't see why third party code would need to either.

Agree here 👍