detekt / sarif4k

Kotlin data bindings for the Static Analysis Results Interchange Format (SARIF)
Apache License 2.0
15 stars 7 forks source link

Mac CI/CD fails because of Java 8 #119

Closed TWiStErRob closed 5 days ago

TWiStErRob commented 2 months ago

https://github.com/actions/setup-java/issues/625 -> https://github.com/actions/setup-java/issues/625#issuecomment-2096064399

Probably caused by: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/

Probable solution:

-macos-latest
+macos-13 # Java 8 is not supported on macos-14+ (M1).

I saw now new issue related to this at https://github.com/actions/runner-images/issues

TWiStErRob commented 6 days ago

@detekt/maintainers thoughts? Repo is being blocked from any maintenance.

3flex commented 6 days ago

Downgrade to macOS 13 for now I think.

11 is still supported by GitHub runners (though deprecated), so there's quite some time until 13 is dropped.

Alternatively move to a Java distribution that supports Java 8 on aarch64 (Coretto or Zulu for example).

TWiStErRob commented 5 days ago

Merged a fix to unblock the dependency updates, we can change it if the solution is not the best.

Matthew's comment made me realise that we should stay on latest of machine because it should be faster during compilation even if it needs to download a Java.