Open DenisYelkin opened 6 months ago
No idea how we didn't pick up this PR earliear. In the meantime we changed that part of the code a lot. Basically we move the responsability of merging two different reports to sarif4k
. Can you check if this issue is still present in the new implementation? To be honest I don't use sarif that much so I don't understand completely the issue.
If it is still there, do you want to create a PR fixing it? The merge code is kind of simple so it shouldn't be difficult to implement: https://github.com/detekt/sarif4k/blob/main/src/commonMain/kotlin/io/github/detekt/sarif4k/Merging.kt
SarifReportMerger.kt - merging only results. Without considering
uriBaseId
andoriginalUriBaseIds
. It leads to inability to parse actual artifact location for particular result.Example:
originalUriBaseIds
- has only one reference to modulesecond
. Meanwhile resultsuriBaseId
linked to wrong uri (Utils.kt located in another module).