test: workspace and project page model refactor [TESTENG-48]

JComins000 commented 3 months ago

Ticket

Description

Hey @djanicekpach, this replaces a few of the models you made back when the repo was first new. I didn't do a good enough job reviewing your models at the time, and I wanted to update the models to match the source code better. Ideally, model files should have a 1-to-1 mapping from source code to model, rather than treating DOM as king. In addition, some features in the framework, didn't exist at the time when you made your models, and I updated your helpers to be consistent with the newer patterns in the framework. I'll leave a comment for each change for anyone who drops by to learn from these examples.

Test Plan

Checklist

[ ] Changes have been manually QA'd
[ ] New features have been approved by the corresponding PM
[ ] User-facing API changes have the "User-facing API Change" label
[ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
[ ] Licenses have been included for new code which was copied and/or modified from any external code

netlify[bot] commented 3 months ago

Deploy Preview for determined-ui ready!

Name	Link
Latest commit	a4099e4a9a735c2fa33a191eb8c907c2cacaa95c
Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/667c47221a52710008e1bf42
Deploy Preview	https://deploy-preview-9570--determined-ui.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.19%. Comparing base (aeaae29) to head (a4099e4). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9570 +/- ## ========================================== - Coverage 49.80% 45.19% -4.61% ========================================== Files 1247 923 -324 Lines 162251 121906 -40345 Branches 2888 2888 ========================================== - Hits 80807 55101 -25706 + Misses 81272 66633 -14639 Partials 172 172 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9570/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `?` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `46.16% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. [see 334 files with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9570/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)

determined-ai / determined