determined-ai / determined

Determined is an open-source machine learning platform that simplifies distributed training, hyperparameter tuning, experiment tracking, and resource management. Works with PyTorch and TensorFlow.
https://determined.ai
Apache License 2.0
3k stars 350 forks source link

chore: stop enabling all in Go linters [RM-346] #9583

Closed NicholasBlaskey closed 3 months ago

NicholasBlaskey commented 3 months ago

Ticket

Description

Switch to a allow list approach on Go linters rather than the deny list approach we took.

Linters list made with golangci-lint linters

Test Plan

CI passes, make sure linters still work by checking bad code gets caught

Checklist

netlify[bot] commented 3 months ago

Deploy Preview for determined-ui canceled.

Name Link
Latest commit 83165cdfdb7550b7388e9e96a9ea962cc3dab9b3
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6682e07c5718cd0008b66b5b
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.35%. Comparing base (664a1c0) to head (83165cd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9583 +/- ## ========================================== - Coverage 51.36% 51.35% -0.02% ========================================== Files 1252 1252 Lines 152174 152174 Branches 3024 3024 ========================================== - Hits 78171 78153 -18 - Misses 73845 73863 +18 Partials 158 158 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9583/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/determined-ai/determined/pull/9583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `43.97% <ø> (-0.04%)` | :arrow_down: | | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `72.80% <ø> (ø)` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `47.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. [see 6 files with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9583/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)