determined-ai / determined

Determined is an open-source machine learning platform that simplifies distributed training, hyperparameter tuning, experiment tracking, and resource management. Works with PyTorch and TensorFlow.
https://determined.ai
Apache License 2.0
3k stars 350 forks source link

chore: Revert "remove circular dependence + correctly derive values" #9590

Closed keita-determined closed 3 months ago

keita-determined commented 3 months ago

This reverts commit 7e3f27b455b5f9da11ebc764b7c50f3c01a1f109. The commit is accidentally pushed into main branch

Ticket

Description

Ci pass

Test Plan

Checklist

netlify[bot] commented 3 months ago

Deploy Preview for determined-ui ready!

Name Link
Latest commit f577c9147ca4e29fe8545e4c4f3d7fdcfd904707
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/667de0b6fd9f6000072f65d0
Deploy Preview https://deploy-preview-9590--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 47.43%. Comparing base (bd633f1) to head (f577c91).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9590 +/- ## ========================================== - Coverage 51.32% 47.43% -3.90% ========================================== Files 1252 435 -817 Lines 152046 73074 -78972 Branches 3019 3019 ========================================== - Hits 78041 34662 -43379 + Misses 73846 38253 -35593 Partials 159 159 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9590/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Ξ” | | |---|---|---| | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `?` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `47.89% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/determined-ai/determined/pull/9590?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Ξ” | | |---|---|---| | [webui/react/src/pages/WorkspaceDetails.tsx](https://app.codecov.io/gh/determined-ai/determined/pull/9590?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Fpages%2FWorkspaceDetails.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL3BhZ2VzL1dvcmtzcGFjZURldGFpbHMudHN4) | `0.00% <0.00%> (ΓΈ)` | | ... and [817 files with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9590/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)