fix: lint issue from flake8-comprehensions 3.15.0

jgongd commented 2 weeks ago

Ticket

Description

flake8-comprehensions was updated from 3.14.0 to 3.15.0 over the weekend. Some of the code couldn't pass lint check.

Test Plan

CI passes.

Checklist

[ ] Changes have been manually QA'd
[ ] New features have been approved by the corresponding PM
[ ] User-facing API changes have the "User-facing API Change" label
[ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
[ ] Licenses have been included for new code which was copied and/or modified from any external code

netlify[bot] commented 2 weeks ago

Deploy Preview for determined-ui ready!

Name	Link
Latest commit	53bbc0d1beb7be62f13db13f9410dcf0eee6aa77
Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/6682cd9f08e15400087f17ef
Deploy Preview	https://deploy-preview-9596--determined-ui.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.35%. Comparing base (8a47454) to head (53bbc0d). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9596 +/- ## ========================================== - Coverage 51.35% 51.35% -0.01% ========================================== Files 1252 1252 Lines 152174 152174 Branches 3024 3024 ========================================== - Hits 78153 78151 -2 - Misses 73863 73865 +2 Partials 158 158 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/determined-ai/determined/pull/9596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `43.96% <ø> (-0.01%)` | :arrow_down: | | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `72.80% <0.00%> (ø)` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `47.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/determined-ai/determined/pull/9596?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [harness/determined/common/api/\_rbac.py](https://app.codecov.io/gh/determined-ai/determined/pull/9596?src=pr&el=tree&filepath=harness%2Fdetermined%2Fcommon%2Fapi%2F_rbac.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-aGFybmVzcy9kZXRlcm1pbmVkL2NvbW1vbi9hcGkvX3JiYWMucHk=) | `16.39% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9596/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)

determined-ai / determined